]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mm: open-code PageTail in folio_flags() and const_folio_flags()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 25 Nov 2024 20:17:18 +0000 (20:17 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:33 +0000 (20:03 +0100)
commit1dde3fde62b7cdb4bac37f89b29e079bf2a9b004
treebee091d8532903962f1d111359124eb279df96db
parent35e8f9125d3c7c8aef5fa74ad183674892954936
mm: open-code PageTail in folio_flags() and const_folio_flags()

commit 4de22b2a6a7477d84d9a01eb6b62a9117309d722 upstream.

It is unsafe to call PageTail() in dump_page() as page_is_fake_head() will
almost certainly return true when called on a head page that is copied to
the stack.  That will cause the VM_BUG_ON_PGFLAGS() in const_folio_flags()
to trigger when it shouldn't.  Fortunately, we don't need to call
PageTail() here; it's fine to have a pointer to a virtual alias of the
page's flag word rather than the real page's flag word.

Link: https://lkml.kernel.org/r/20241125201721.2963278-1-willy@infradead.org
Fixes: fae7d834c43c ("mm: add __dump_folio()")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Kees Cook <kees@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/page-flags.h