]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: dice: fix buffer overflow in detect_stream_formats()
authorJunrui Luo <moonafterrain@outlook.com>
Fri, 28 Nov 2025 04:06:31 +0000 (12:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 13:03:42 +0000 (14:03 +0100)
commit1e1b3207a53e50d5a66289fffc1f7d52cd9c50f9
treeb7e7aa8db3f4b73875a2e710aa2ece042d0aa127
parentd6d0caff738fafc20eb242433685b398f9158314
ALSA: dice: fix buffer overflow in detect_stream_formats()

commit 324f3e03e8a85931ce0880654e3c3eb38b0f0bba upstream.

The function detect_stream_formats() reads the stream_count value directly
from a FireWire device without validating it. This can lead to
out-of-bounds writes when a malicious device provides a stream_count value
greater than MAX_STREAMS.

Fix by applying the same validation to both TX and RX stream counts in
detect_stream_formats().

Reported-by: Yuhao Jiang <danisjiang@gmail.com>
Reported-by: Junrui Luo <moonafterrain@outlook.com>
Fixes: 58579c056c1c ("ALSA: dice: use extended protocol to detect available stream formats")
Cc: stable@vger.kernel.org
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
Link: https://patch.msgid.link/SYBPR01MB7881B043FC68B4C0DA40B73DAFDCA@SYBPR01MB7881.ausprd01.prod.outlook.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/firewire/dice/dice-extension.c