]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: btusb: revert use of devm_kzalloc in btusb
authorRaphael Pinsonneault-Thibeault <rpthibeault@gmail.com>
Wed, 10 Dec 2025 16:02:28 +0000 (11:02 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:32 +0000 (10:14 +0100)
commit1e54c19eaf84ba652c4e376571093e58e144b339
treece610dcf482db28bbc42e03d56a6d590f2932043
parentccbb96434d88e32358894c879457b33f7508e798
Bluetooth: btusb: revert use of devm_kzalloc in btusb

[ Upstream commit 252714f1e8bdd542025b16321c790458014d6880 ]

This reverts commit 98921dbd00c4e ("Bluetooth: Use devm_kzalloc in
btusb.c file").

In btusb_probe(), we use devm_kzalloc() to allocate the btusb data. This
ties the lifetime of all the btusb data to the binding of a driver to
one interface, INTF. In a driver that binds to other interfaces, ISOC
and DIAG, this is an accident waiting to happen.

The issue is revealed in btusb_disconnect(), where calling
usb_driver_release_interface(&btusb_driver, data->intf) will have devm
free the data that is also being used by the other interfaces of the
driver that may not be released yet.

To fix this, revert the use of devm and go back to freeing memory
explicitly.

Fixes: 98921dbd00c4e ("Bluetooth: Use devm_kzalloc in btusb.c file")
Signed-off-by: Raphael Pinsonneault-Thibeault <rpthibeault@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bluetooth/btusb.c