]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rcutorture: Fix rcu_torture_fwd_cb_cr() data race
authorPaul E. McKenney <paulmck@kernel.org>
Fri, 5 Apr 2024 19:02:11 +0000 (12:02 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:06 +0000 (15:34 +0200)
commit1e67ea9f705870fd9e7d583d004ef6d295526c77
treefd066e44829c4045aa426aaca8049c0e04662e30
parent5da3af03c9fea7a92518bb0469635d33191c56b9
rcutorture: Fix rcu_torture_fwd_cb_cr() data race

[ Upstream commit 6040072f4774a575fa67b912efe7722874be337b ]

On powerpc systems, spinlock acquisition does not order prior stores
against later loads.  This means that this statement:

rfcp->rfc_next = NULL;

Can be reordered to follow this statement:

WRITE_ONCE(*rfcpp, rfcp);

Which is then a data race with rcu_torture_fwd_prog_cr(), specifically,
this statement:

rfcpn = READ_ONCE(rfcp->rfc_next)

KCSAN located this data race, which represents a real failure on powerpc.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Marco Elver <elver@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: <kasan-dev@googlegroups.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/rcu/rcutorture.c