]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bonding: correctly process non-linear skbs
authorAndy Gospodarek <andy@greyhouse.net>
Fri, 10 Sep 2010 11:43:20 +0000 (11:43 +0000)
committerWilly Tarreau <w@1wt.eu>
Sat, 11 Feb 2012 14:38:34 +0000 (15:38 +0100)
commit1ec33da41cf07f6cc9a2f6886bf41f396e74c9cf
tree8401ebc1d48df934102e33f9e4d77bf659f1e61a
parent64494d9f150b905efc2a9112e1cb3777f7fcabba
bonding: correctly process non-linear skbs

commit ab12811c89e88f2e66746790b1fe4469ccb7bdd9 upstream.

It was recently brought to my attention that 802.3ad mode bonds would no
longer form when using some network hardware after a driver update.
After snooping around I realized that the particular hardware was using
page-based skbs and found that skb->data did not contain a valid LACPDU
as it was not stored there.  That explained the inability to form an
802.3ad-based bond.  For balance-alb mode bonds this was also an issue
as ARPs would not be properly processed.

This patch fixes the issue in my tests and should be applied to 2.6.36
and as far back as anyone cares to add it to stable.

Thanks to Alexander Duyck <alexander.h.duyck@intel.com> and Jesse
Brandeburg <jesse.brandeburg@intel.com> for the suggestions on this one.

Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
CC: Alexander Duyck <alexander.h.duyck@intel.com>
CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/net/bonding/bond_3ad.c
drivers/net/bonding/bond_alb.c