]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
block: change blk_get_meta_cap() stub return -ENOIOCTLCMD
authorKlara Modin <klarasmodin@gmail.com>
Fri, 25 Jul 2025 16:43:34 +0000 (18:43 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 28 Jul 2025 23:14:18 +0000 (16:14 -0700)
commit1edaac340f4da813b258a5e3a6c79804612161a4
tree89cb58451df168c3c60275b56d6490d85da1f5d5
parent595d7ebeaf39ee08180e00fdecf3576a2d702e01
block: change blk_get_meta_cap() stub return -ENOIOCTLCMD

When introduced in commit 9eb22f7fedfc ("fs: add ioctl to query metadata
and protection info capabilities") the stub of blk_get_meta_cap() for
!BLK_DEV_INTEGRITY always returns -EOPNOTSUPP.  The motivation was that
while the command was unsupported in that configuration it was still
recognized.

A later change instead assumed -ENOIOCTLCMD as is required for unknown
ioctl commands per Documentation/driver-api/ioctl.rst. The result being
that on !BLK_DEV_INTEGRITY configs, any ioctl which reaches
blkdev_common_ioctl() will return -EOPNOTSUPP.

Change the stub to return -ENOIOCTLCMD, fixing the issue and better
matching with expectations.

[ The blkdev_common_ioctl() confusion has been fixed, but -ENOIOCTLCMD
  is the right thing to return for unrecognized ioctls, so the patch
  remains the right thing to do.   - Linus ]

Link: https://lore.kernel.org/lkml/CACzX3AsRd__fXb9=CJPTTJC494SDnYAtYrN2=+bZgMCvM6UQDg@mail.gmail.com
Fixes: 42b0ef01e6b5 ("block: fix FS_IOC_GETLBMD_CAP parsing in blkdev_common_ioctl()")
Signed-off-by: Klara Modin <klarasmodin@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/blk-integrity.h