]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
wifi: rtw88: fix the 'para' buffer size to avoid reading out of bounds
authorAlexey Kodanev <aleksei.kodanev@bell-sw.com>
Tue, 13 May 2025 12:13:04 +0000 (12:13 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:05:13 +0000 (11:05 +0100)
commit1ee8ea6937d13b20f90ff35d71ccc03ba448182d
treeef8458a53f2d155108800a3bf71e5e3bfd0499dd
parent7f9efa13f2af6516f609257863fe38746ecb502c
wifi: rtw88: fix the 'para' buffer size to avoid reading out of bounds

[ Upstream commit 4c2c372de2e108319236203cce6de44d70ae15cd ]

Set the size to 6 instead of 2, since 'para' array is passed to
'rtw_fw_bt_wifi_control(rtwdev, para[0], &para[1])', which reads
5 bytes:

void rtw_fw_bt_wifi_control(struct rtw_dev *rtwdev, u8 op_code, u8 *data)
{
    ...
    SET_BT_WIFI_CONTROL_DATA1(h2c_pkt, *data);
    SET_BT_WIFI_CONTROL_DATA2(h2c_pkt, *(data + 1));
    ...
    SET_BT_WIFI_CONTROL_DATA5(h2c_pkt, *(data + 4));

Detected using the static analysis tool - Svace.
Fixes: 4136214f7c46 ("rtw88: add BT co-existence support")
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250513121304.124141-1-aleksei.kodanev@bell-sw.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw88/coex.c