]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virsh: Fix "positional" argument annotations for 'migrate' command
authorPeter Krempa <pkrempa@redhat.com>
Wed, 13 Mar 2024 21:52:12 +0000 (22:52 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Apr 2024 12:24:29 +0000 (14:24 +0200)
commit1efb7944878d2a6610e358faef0fefbdb9174817
treed1144393a15e922d2eb11b8140054279eac6cef3
parent39218865f46afef980fcd50f7c3d19b6b9b30f6c
virsh: Fix "positional" argument annotations for 'migrate' command

Annotate arguments which can be unintentionally parsed positionally.
(See previous commits for explanation.)

Annotate '--migrateuri', '--graphicsuri', '--listen-address', '-dname',
'--timeout', '--xml', '--migrate-disks' and '--disks port' as
'unwanted_positional'. These were declared in chronological order per
git history.

All others are annotated with VSH_OFLAG_REQ_OPT which makes the parser
require the '--optionname'. This is due to the fact that '--disks-uri'
was introduced later and put in front of others declared earlier
breaking the order they would be accepted, thus changing the behaviour
between versions.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-domain.c