]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: qla2xxx: Fix incorrect sign of error code in START_SP_W_RETRIES()
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 5 Sep 2025 07:54:44 +0000 (15:54 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 Sep 2025 02:05:00 +0000 (22:05 -0400)
commit1f037e3acda79639a78f096355f2c308a3d45492
tree995ddd36d75e498ef26f6146ab413a800e21d821
parent066b8f3fa85c1be7fb7dbae202231e131d38f7bc
scsi: qla2xxx: Fix incorrect sign of error code in START_SP_W_RETRIES()

Change the error code EAGAIN to -EAGAIN in START_SP_W_RETRIES() to align
with qla2x00_start_sp() returning negative error codes or QLA_SUCCESS,
preventing logical errors.  Additionally, the '_rval' variable should
store negative error codes to conform to Linux kernel error code
conventions.

Fixes: 9803fb5d2759 ("scsi: qla2xxx: Fix task management cmd failure")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Message-ID: <20250905075446.381139-3-rongqianfeng@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_init.c