]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: codecs: wsa881x: Correct Soundwire ports mask
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 26 Jul 2024 14:10:44 +0000 (16:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:20 +0000 (15:34 +0200)
commit1f05464ae0c8f221449655b4c87bfdc41caad1a0
treee487d95ad4448909aa96d795026e91468b2a444b
parentee40a8d9262158f3d4696d71dfd14ebbb238b4e6
ASoC: codecs: wsa881x: Correct Soundwire ports mask

[ Upstream commit eb11c3bb64ad0a05aeacdb01039863aa2aa3614b ]

Device has up to WSA881X_MAX_SWR_PORTS number of ports and the array
assigned to prop.sink_dpn_prop has 0..WSA881X_MAX_SWR_PORTS-1 elements.
On the other hand, GENMASK(high, low) creates an inclusive mask between
<high, low>, so we need the mask from 0 up to WSA881X_MAX_SWR_PORTS-1.

Theoretically, too wide mask could cause an out of bounds read in
sdw_get_slave_dpn_prop() in stream.c, however only in the case of buggy
driver, e.g. adding incorrect number of ports via
sdw_stream_add_slave().

Fixes: a0aab9e1404a ("ASoC: codecs: add wsa881x amplifier support")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240726-asoc-wcd-wsa-swr-ports-genmask-v1-4-d4d7a8b56f05@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wsa881x.c