]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: st: Tighten the page format heuristics with MODE SELECT
authorKai Mäkisara <Kai.Makisara@kolumbus.fi>
Tue, 11 Mar 2025 11:25:16 +0000 (13:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:05 +0000 (14:40 +0200)
commit1f20b8eccf01bbd3be34a4f8d7c3ee3f331ac814
tree1d01b6c6c10f59dc344be05fe9ab6cc882461796
parent7f778cbffe807f3997426fc6bae92063bb3dd0e5
scsi: st: Tighten the page format heuristics with MODE SELECT

[ Upstream commit 8db816c6f176321e42254badd5c1a8df8bfcfdb4 ]

In the days when SCSI-2 was emerging, some drives did claim SCSI-2 but did
not correctly implement it. The st driver first tries MODE SELECT with the
page format bit set to set the block descriptor.  If not successful, the
non-page format is tried.

The test only tests the sense code and this triggers also from illegal
parameter in the parameter list. The test is limited to "old" devices and
made more strict to remove false alarms.

Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Link: https://lore.kernel.org/r/20250311112516.5548-4-Kai.Makisara@kolumbus.fi
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/st.c