]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: cdc-acm: fix use-after-free after probe failure
authorJohan Hovold <johan@kernel.org>
Mon, 22 Mar 2021 15:53:12 +0000 (16:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Apr 2021 10:04:22 +0000 (12:04 +0200)
commit1f39a43e67cff4b84b8549133f696f7ba475b1d7
treeb4a0c9680d2a37e1abc5acac796c3ae562821379
parent8e422c16d35206b05e9ea970708c6f2aaed5e261
USB: cdc-acm: fix use-after-free after probe failure

commit 4e49bf376c0451ad2eae2592e093659cde12be9a upstream.

If tty-device registration fails the driver would fail to release the
data interface. When the device is later disconnected, the disconnect
callback would still be called for the data interface and would go about
releasing already freed resources.

Fixes: c93d81955005 ("usb: cdc-acm: fix error handling in acm_probe()")
Cc: stable@vger.kernel.org # 3.9
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20210322155318.9837-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c