]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: qat - fix seq_file position update in adf_ring_next()
authorGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Mon, 14 Jul 2025 07:10:29 +0000 (08:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 10:05:04 +0000 (12:05 +0200)
commit1f3c8ca0639d77e397fd44f8ada1fb80f27a3c09
treede851cabe1ed9d8312a785b1b921e03dd472c115
parentc0cbc65753cc4a39e2d0990cfd19515d226945a5
crypto: qat - fix seq_file position update in adf_ring_next()

[ Upstream commit 6908c5f4f066a0412c3d9a6f543a09fa7d87824b ]

The `adf_ring_next()` function in the QAT debug transport interface
fails to correctly update the position index when reaching the end of
the ring elements. This triggers the following kernel warning when
reading ring files, such as
/sys/kernel/debug/qat_c6xx_<D:B:D:F>/transport/bank_00/ring_00:

   [27725.022965] seq_file: buggy .next function adf_ring_next [intel_qat] did not update position index

Ensure that the `*pos` index is incremented before returning NULL when
after the last element in the ring is found, satisfying the seq_file API
requirements and preventing the warning.

Fixes: a672a9dc872e ("crypto: qat - Intel(R) QAT transport code")
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Ahsan Atta <ahsan.atta@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/qat/qat_common/adf_transport_debug.c