]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect/alert: ensure reject action is applied
authorJuliana Fajardini <jufajardini@oisf.net>
Thu, 28 Jul 2022 23:05:47 +0000 (20:05 -0300)
committerVictor Julien <vjulien@oisf.net>
Thu, 25 Aug 2022 10:38:08 +0000 (12:38 +0200)
commit1f54e8611ab39ce3509280574d137df23c325658
treec2f25f305ed403a21c3ee3bfcd1f5663bd67299a
parent1774ff18a6ab28233f7b31e0fb6b799d81abf34d
detect/alert: ensure reject action is applied

Bug 5458 states that the reject action is no longer working. While SV
tests that use the reject action still pass, it indeed seems that a
regression has happened with commit aa93984, because while the
function that applies rule actions to the flow (RuleActionToFlow) does
check for the reject action, the newly added function PacketApply
SignatureActions only checks for ACTION_DROP or ACTION_PASS when
deciding to call RuleActionToFlow.

Bug #5458
src/detect-engine-alert.c
src/detect-engine-threshold.c