]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xfs: attr forks require attr, not attr2
authorDarrick J. Wong <djwong@kernel.org>
Wed, 11 Jun 2025 21:01:22 +0000 (14:01 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:20 +0000 (11:07 +0100)
commit1ff15a67aad5205184d7e43360f9ada1dbf42344
tree2ff8a7c6191c62dfba8577fa1b5b8eb83b4ebdf4
parent3ec6c4f041fb6501ea95faa49f0b777c36fa3b8e
xfs: attr forks require attr, not attr2

[ Upstream commit 73c34b0b85d46bf9c2c0b367aeaffa1e2481b136 ]

It turns out that I misunderstood the difference between the attr and
attr2 feature bits.  "attr" means that at some point an attr fork was
created somewhere in the filesystem.  "attr2" means that inodes have
variable-sized forks, but says nothing about whether or not there
actually /are/ attr forks in the system.

If we have an attr fork, we only need to check that attr is set.

Fixes: 99d9d8d05da26 ("xfs: scrub inode block mappings")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
Acked-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/xfs/scrub/bmap.c