]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-102506)
authorEric Snow <ericsnowcurrently@gmail.com>
Tue, 14 Mar 2023 16:05:54 +0000 (10:05 -0600)
committerGitHub <noreply@github.com>
Tue, 14 Mar 2023 16:05:54 +0000 (10:05 -0600)
commit1ff81c0cb67215694f084e51c4d35ae53b9f5cf9
treee8067aff7f52f7b17284caa3452b17a98a9ae1bc
parenta703f743dbf2675948e59c44fa9d7112f7825100
gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-102506)

This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.

FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.

Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.

This also resolves gh-100237.

https://github.com/python/cpython/issues/81057
.github/workflows/build.yml
Lib/test/test_check_c_globals.py [deleted file]
Makefile.pre.in
Tools/c-analyzer/c_parser/preprocessor/common.py
Tools/c-analyzer/c_parser/preprocessor/gcc.py
Tools/c-analyzer/cpython/__main__.py
Tools/c-analyzer/cpython/_parser.py
Tools/c-analyzer/cpython/ignored.tsv