]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rfkill: fix rfkill_fop_read wait_event usage
authorJohannes Berg <johannes.berg@intel.com>
Tue, 26 Jan 2016 10:29:03 +0000 (11:29 +0100)
committerWilly Tarreau <w@1wt.eu>
Sat, 12 Mar 2016 13:25:42 +0000 (14:25 +0100)
commit2048f19dd0b3a0db765ddda98d808b2d83d76c7b
tree32abad90e26543c9394ef0374c0b65f63d55b862
parent2bd8e6793e5ada59a0a1f74bd10266258a54c946
rfkill: fix rfkill_fop_read wait_event usage

commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 upstream.

The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().

Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.

This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.

Fixes: c64fb01627e24 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/rfkill/core.c