]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: mangle zero checksum in skb_checksum_help()
authorEric Dumazet <edumazet@google.com>
Sat, 29 Oct 2016 18:02:36 +0000 (11:02 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 16 Mar 2017 02:27:20 +0000 (02:27 +0000)
commit206f4e16ea87b9fc5700cebdb0be1daa2725291e
tree44ca1d7f5fcb5469d1e09d850dbd29a65971422a
parent4ecc76bd3f1b45cd31b4c88bdd8d77bf998a471e
net: mangle zero checksum in skb_checksum_help()

[ Upstream commit 4f2e4ad56a65f3b7d64c258e373cb71e8d2499f4 ]

Sending zero checksum is ok for TCP, but not for UDP.

UDPv6 receiver should by default drop a frame with a 0 checksum,
and UDPv4 would not verify the checksum and might accept a corrupted
packet.

Simply replace such checksum by 0xffff, regardless of transport.

This error was caught on SIT tunnels, but seems generic.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Acked-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/dev.c