]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ovl: don't fail copy up if no fileattr support on upper
authorMiklos Szeredi <mszeredi@redhat.com>
Fri, 14 Jan 2022 15:57:56 +0000 (16:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Feb 2022 11:39:54 +0000 (12:39 +0100)
commit20842a8d93e3a595dbb49038588e4c994a500ccb
tree3173574da8be5c2909acaac7ba1eb09016294a40
parent2c6be97ad899ad1c1632b6138c2547e53e733a30
ovl: don't fail copy up if no fileattr support on upper

commit 94fd19752b28aa66c98e7991734af91dfc529f8f upstream.

Christoph Fritz is reporting that failure to copy up fileattr when upper
doesn't support fileattr or xattr results in a regression.

Return success in these failure cases; this reverts overlayfs to the old
behavior.

Add a pr_warn_once() in these cases to still let the user know about the
copy up failures.

Reported-by: Christoph Fritz <chf.fritz@googlemail.com>
Fixes: 72db82115d2b ("ovl: copy up sync/noatime fileattr flags")
Cc: <stable@vger.kernel.org> # v5.15
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/overlayfs/copy_up.c