]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: storage: pool: reject name containing '/'
authorCole Robinson <crobinso@redhat.com>
Tue, 26 Apr 2016 18:51:33 +0000 (14:51 -0400)
committerCole Robinson <crobinso@redhat.com>
Mon, 2 May 2016 14:06:04 +0000 (10:06 -0400)
commit20b52668dd1300184280a1c8205370b12f0c3c63
treeb9052562f02ff9d34a8f5b2ec5c0d6d67ef8b8d5
parent454f739f24a936aedec48c3a3ba659b374ce251a
conf: storage: pool: reject name containing '/'

Trying to define a pool name containing an embedded '/'
will immediately fail when trying to write the XML to disk.
This patch explicitly rejects names containing a '/'

Besides our stateful driver, there are two other storage impls:
esx and phyp. esx doesn't support pool creation, so this should
doesn't apply.

phyp does support pool creation, and the name is passed to the
'mksp' tool, which google doesn't reveal whether it accepts '/'
or not. IMO the likeliness of this impacting any users is near zero
src/conf/storage_conf.c