]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: ad7768-1: Call iio_trigger_notify_done() on error
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 1 Nov 2021 14:40:55 +0000 (15:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 13:49:06 +0000 (14:49 +0100)
commit20f0fb418b6cd4564098d1e3cbb7ef40cfa6d15f
tree08f7e11e012a3b43e33385e293204a6bf9fa5872
parentb68f44829b7365a9db4e3cef20ea874125b686a7
iio: ad7768-1: Call iio_trigger_notify_done() on error

commit 6661146427cbbce6d1fe3dbb11ff1c487f55799a upstream.

IIO trigger handlers must call iio_trigger_notify_done() when done. This
must be done even when an error occurred. Otherwise the trigger will be
seen as busy indefinitely and the trigger handler will never be called
again.

The ad7768-1 driver neglects to call iio_trigger_notify_done() when there
is an error reading the converter data. Fix this by making sure that
iio_trigger_notify_done() is included in the error exit path.

Fixes: a5f8c7da3dbe ("iio: adc: Add AD7768-1 ADC basic support")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20211101144055.13858-2-lars@metafoo.de
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/ad7768-1.c