]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.
authorAndres Freund <andres@anarazel.de>
Tue, 9 Jun 2020 02:52:19 +0000 (19:52 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 9 Jun 2020 03:03:09 +0000 (20:03 -0700)
commit20fd90febc2c2429a0340d476cccc6922f581305
tree03bf870ae1f4af24f422605d073a8d23b78348e3
parentfd11b842eba944d62014f7072b0c76e36cbe652e
Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.

Previously we used pg_atomic_write_64_impl inside
pg_atomic_init_u64. That works correctly, but on platforms without
64bit single copy atomicity it could trigger spurious valgrind errors
about uninitialized memory, because we use compare_and_swap for atomic
writes on such platforms.

I previously suppressed one instance of this problem (6c878edc1df),
but as Tom reports that wasn't enough. As the atomic variable cannot
yet be concurrently accessible during initialization, it seems better
to have pg_atomic_init_64_impl set the value directly.

Change pg_atomic_init_u32_impl for symmetry.

Reported-By: Tom Lane
Author: Andres Freund
Discussion: https://postgr.es/m/1714601.1591503815@sss.pgh.pa.us
Backpatch: 9.5-
src/include/port/atomics/generic.h
src/tools/valgrind.supp