]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/vmwgfx: Fix invalid kref_put callback in vmw_bo_dirty_release
authorBrad Spengler <brad.spengler@opensrcsec.com>
Wed, 7 Jan 2026 17:12:36 +0000 (12:12 -0500)
committerZack Rusin <zack.rusin@broadcom.com>
Thu, 5 Feb 2026 17:43:51 +0000 (12:43 -0500)
commit211ecfaaef186ee5230a77d054cdec7fbfc6724a
treed3f633c4a0506730cdf60306003b2fea12257b09
parent40b24d9cdd4141ef43eeaa7e57c3efc07a567473
drm/vmwgfx: Fix invalid kref_put callback in vmw_bo_dirty_release

The kref_put() call uses (void *)kvfree as the release callback, which
is incorrect. kref_put() expects a function with signature
void (*release)(struct kref *), but kvfree has signature
void (*)(const void *). Calling through an incompatible function pointer
is undefined behavior.

The code only worked by accident because ref_count is the first member
of vmw_bo_dirty, making the kref pointer equal to the struct pointer.

Fix this by adding a proper release callback that uses container_of()
to retrieve the containing structure before freeing.

Fixes: c1962742ffff ("drm/vmwgfx: Use kref in vmw_bo_dirty")
Signed-off-by: Brad Spengler <brad.spengler@opensrcsec.com>
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Cc: Ian Forbes <ian.forbes@broadcom.com>
Link: https://patch.msgid.link/20260107171236.3573118-1-zack.rusin@broadcom.com
drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c