]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) (GH-9149)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 11 Sep 2018 06:00:47 +0000 (23:00 -0700)
committerGregory P. Smith <greg@krypto.org>
Tue, 11 Sep 2018 06:00:47 +0000 (23:00 -0700)
commit2173bb818c6c726d831b106ed0d3fad7825905dc
tree80a9cfd2786272e44efcfc00b9184317635da970
parentb2260e59ff1eaf20de4738099005ddf507b7b27d
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) (GH-9149)

When subprocess.Popen() stdin= stdout= or stderr= handles are specified
and appear in pass_fds=, don't close the original fds after dup'ing them.

This implementation and unittest primarily came from @izbyshev (see the PR)

See also https://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c

This also removes the old manual p2cread, c2pwrite, and errwrite closing logic
as inheritable flags and _close_open_fds takes care of that properly today without special treatment.

This code is within child_exec() where it is the only thread so there is no
race condition between the dup and _Py_set_inheritable_async_safe call.
(cherry picked from commit ce34410b8b67f49d8275c05d51b3ead50cf97f48)

Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google]
Lib/test/test_subprocess.py
Misc/NEWS.d/next/Library/2018-09-10-14-15-53.bpo-32270.wSJjuD.rst [new file with mode: 0644]
Modules/_posixsubprocess.c