]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xhci: fix isoc endpoint dequeue from advancing too far on transaction error
authorMathias Nyman <mathias.nyman@linux.intel.com>
Thu, 30 Apr 2015 14:16:02 +0000 (17:16 +0300)
committerSasha Levin <sasha.levin@oracle.com>
Wed, 10 Jun 2015 17:42:15 +0000 (13:42 -0400)
commit21792ca9e9b5cab0338ac3804d97d50460da5cfd
tree460539394c0085439a6e5ce1986244b3d377bd11
parente0bc573f09efd4c681e94d3260722646934b9051
xhci: fix isoc endpoint dequeue from advancing too far on transaction error

[ Upstream commit d104d0152a97fade389f47635b73a9ccc7295d0b ]

Isoc TDs usually consist of one TRB, sometimes two. When all goes well we
receive only one success event for a TD, and move the dequeue pointer to
the next TD.

This fails if the TD consists of two TRBs and we get a transfer error
on the first TRB, we will then see two events for that TD.

Fix this by making sure the event we get is for the last TRB in that TD
before moving the dequeue pointer to the next TD. This will resolve some
of the uvc and dvb issues with the
"ERROR Transfer event TRB DMA ptr not part of current TD" error message

Cc: <stable@vger.kernel.org>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/usb/host/xhci-ring.c