]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
af_unix: annotate unix_gc_lock with __cacheline_aligned_in_smp
authorMateusz Guzik <mjguzik@gmail.com>
Wed, 3 Dec 2025 10:01:22 +0000 (11:01 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Dec 2025 07:43:24 +0000 (23:43 -0800)
commit2183a5c8a04f554d03174ddcfd0078b44217fa54
tree2a41e937a0c222c01c6cb98c31defd7ed7e616fc
parent0373d5c387f24de749cc22e694a14b3a7c7eb515
af_unix: annotate unix_gc_lock with __cacheline_aligned_in_smp

Otherwise the lock is susceptible to ever-changing false-sharing due to
unrelated changes. This in particular popped up here where an unrelated
change improved performance:
https://lore.kernel.org/oe-lkp/202511281306.51105b46-lkp@intel.com/

Stabilize it with an explicit annotation which also has a side effect
of furher improving scalability:
> in our oiginal report, 284922f4c5 has a 6.1% performance improvement comparing
> to parent 17d85f33a8.
> we applied your patch directly upon 284922f4c5. as below, now by
> "284922f4c5 + your patch"
> we observe a 12.8% performance improvements (still comparing to 17d85f33a8).

Note nothing was done for the other fields, so some fluctuation is still
possible.

Tested-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20251203100122.291550-1-mjguzik@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/unix/garbage.c