]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
irqchip/irq-vt8500: Split up ack/mask functions
authorAlexey Charkov <alchark@gmail.com>
Tue, 6 May 2025 12:46:14 +0000 (16:46 +0400)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 6 May 2025 13:58:26 +0000 (15:58 +0200)
commit22111fdf11666e4ff2bb80481a874a6b958323f2
tree4e92daf3f9df39d2ad7d34bce4e9cd794b2ffe4d
parent76b66e8c9d159eb3d1699e0fa80ceacf9a9ae627
irqchip/irq-vt8500: Split up ack/mask functions

vt8500_irq_mask() really does the ACK for edge triggered interrupts and the
MASK for level triggered interrupts.  Edge triggered interrupts never
really are masked as a result, and there is unnecessary reading of the
status register before the ACK even though it's write-one-to-clear.

Split it up into a proper standalone vt8500_irq_ack() and an unconditional
vt8500_irq_mask().

No Fixes tag added, as it has survived this way for 15 years and nobody
complained, so apparently nothing really used edge triggered interrupts
anyway.

[ tglx: Tabularize the irqchip struct initializer ]

Signed-off-by: Alexey Charkov <alchark@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250506-vt8500-intc-updates-v2-1-a3a0606cf92d@gmail.com
drivers/irqchip/irq-vt8500.c