]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: usb-audio: Fix a memory leak bug
authorWenwen Wang <wang6495@umn.edu>
Sat, 27 Apr 2019 06:06:46 +0000 (01:06 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:54 +0000 (21:11 +0100)
commit22131d100411351f5dd1b3457ef12d7f2539188d
tree56960839e4ca41ae7d676376539a9343c2989b3a
parent5cd237f44b6f3d8897daa92810839c6e50c3b19d
ALSA: usb-audio: Fix a memory leak bug

commit cb5173594d50c72b7bfa14113dfc5084b4d2f726 upstream.

In parse_audio_selector_unit(), the string array 'namelist' is allocated
through kmalloc_array(), and each string pointer in this array, i.e.,
'namelist[]', is allocated through kmalloc() in the following for loop.
Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If
an error occurs during the creation process, the string array 'namelist',
including all string pointers in the array 'namelist[]', should be freed,
before the error code ENOMEM is returned. However, the current code does
not free 'namelist[]', resulting in memory leaks.

To fix the above issue, free all string pointers 'namelist[]' in a loop.

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/usb/mixer.c