]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
virtio_net: Fix skb->csum_start computation
authorMark McLoughlin <markmc@redhat.com>
Mon, 16 Jun 2008 04:41:41 +0000 (14:41 +1000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 22 Jun 2008 05:24:54 +0000 (22:24 -0700)
commit226028e4f78348aa948b1422bda1ede029228d2e
tree8813ed6251bf8a587521134c1bbf3d63a2528369
parent21e99a7b00b6a4b26d0f8111d9c4e3fc8f09ee52
virtio_net: Fix skb->csum_start computation

commit 23cde76d801246a702e7a84c3fe3d655b35c89a1 upstream.

hdr->csum_start is the offset from the start of the ethernet
header to the transport layer checksum field. skb->csum_start
is the offset from skb->head.

skb_partial_csum_set() assumes that skb->data points to the
ethernet header - i.e. it computes skb->csum_start by adding
the headroom to hdr->csum_start.

Since eth_type_trans() skb_pull()s the ethernet header,
skb_partial_csum_set() should be called before
eth_type_trans().

(Without this patch, GSO packets from a guest to the world outside the
host are corrupted).

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/virtio_net.c