]> git.ipfire.org Git - thirdparty/linux.git/commit
soc: qcom: gsbi: fix double disable caused by devm
authorHaotian Zhang <vulab@iscas.ac.cn>
Mon, 20 Oct 2025 16:02:15 +0000 (00:02 +0800)
committerBjorn Andersson <andersson@kernel.org>
Wed, 22 Oct 2025 22:24:52 +0000 (17:24 -0500)
commit2286e18e3937c69cc103308a8c1d4898d8a7b04f
treeae0000fae9e14390636374e09b8fab69a84b6f57
parentdcbce2c23e5edcba2ac538e7a53d0e3d1a21f975
soc: qcom: gsbi: fix double disable caused by devm

In the commit referenced by the Fixes tag, devm_clk_get_enabled() was
introduced to replace devm_clk_get() and clk_prepare_enable(). While
the clk_disable_unprepare() call in the error path was correctly
removed, the one in the remove function was overlooked, leading to a
double disable issue.

Remove the redundant clk_disable_unprepare() call from gsbi_remove()
to fix this issue. Since all resources are now managed by devres
and will be automatically released, the remove function serves no purpose
and can be deleted entirely.

Fixes: 489d7a8cc286 ("soc: qcom: use devm_clk_get_enabled() in gsbi_probe()")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/stable/20251020160215.523-1-vulab%40iscas.ac.cn
Link: https://lore.kernel.org/r/20251020160215.523-1-vulab@iscas.ac.cn
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/qcom_gsbi.c