]> git.ipfire.org Git - thirdparty/coreutils.git/commit
mktemp, sort, tac: don't use undefined after mkstemp failure
authorJim Meyering <meyering@redhat.com>
Wed, 13 Aug 2008 18:53:12 +0000 (20:53 +0200)
committerJim Meyering <meyering@redhat.com>
Thu, 14 Aug 2008 12:37:37 +0000 (14:37 +0200)
commit22999697b81acf3e8683c95c310a36926e7af96f
treef1ef3a5e94aca978886adde6bc0aa4ce6553c1aa
parent7e0019b168241b4edb79cc454d00dfc3344df8c7
mktemp, sort, tac: don't use undefined after mkstemp failure

When mkstemp fails, the template buffer may have undefined
contents, so we must not print it.
* src/sort.c (create_temp_file): Use temp_dir, not "file"
when diagnosing failed mkstemp, because "file" may be undefined.
* tests/misc/sort-merge: Adjust for new expected output.
Jeph Cowan and Ralf Wildenhues reported the test failure:
http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14235/focus=14257
* src/tac.c (copy_to_temp): Don't use template buffer after
failed mkstemp call, since its contents may be undefined.
* tests/misc/tac (pipe-bad-tmpdir): New test for the above.
* src/mktemp.c (main): Save a copy of the template string,
solely for use in case mkstemp fails.
* tests/misc/mktemp (pipe-bad-tmpdir): New test for the above.
THANKS
src/mktemp.c
src/sort.c
src/tac.c
tests/misc/mktemp
tests/misc/sort-merge
tests/misc/tac