]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work()
authorFilipe Manana <fdmanana@suse.com>
Fri, 21 Feb 2025 16:12:15 +0000 (16:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:04 +0000 (14:40 +0200)
commit22bb11b3d53403518d728ca10086acfe3ab84a3b
treed63137886e7474f13779923818a699299e5374df
parente2965d9d21e5f36cdc5f94bb4cfd82ce52c53da3
btrfs: get zone unusable bytes while holding lock at btrfs_reclaim_bgs_work()

[ Upstream commit 1283b8c125a83bf7a7dbe90c33d3472b6d7bf612 ]

At btrfs_reclaim_bgs_work(), we are grabbing a block group's zone unusable
bytes while not under the protection of the block group's spinlock, so
this can trigger race reports from KCSAN (or similar tools) since that
field is typically updated while holding the lock, such as at
__btrfs_add_free_space_zoned() for example.

Fix this by grabbing the zone unusable bytes while we are still in the
critical section holding the block group's spinlock, which is right above
where we are currently grabbing it.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/block-group.c