]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rapidio: fix an API misues when rio_add_net() fails
authorHaoxiang Li <haoxiang_li2024@163.com>
Thu, 27 Feb 2025 07:34:09 +0000 (15:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 12:01:58 +0000 (13:01 +0100)
commit22e4977141dfc6d109bf29b495bf2187b4250990
tree27cd8ed2592d8b36fdc293cdc18d00aa674a735f
parentc332f3e2df0fcae5a45fd55cc18902fb1e4825ca
rapidio: fix an API misues when rio_add_net() fails

commit b2ef51c74b0171fde7eb69b6152d3d2f743ef269 upstream.

rio_add_net() calls device_register() and fails when device_register()
fails.  Thus, put_device() should be used rather than kfree().  Add
"mport->net = NULL;" to avoid a use after free issue.

Link: https://lkml.kernel.org/r/20250227073409.3696854-1-haoxiang_li2024@163.com
Fixes: e8de370188d0 ("rapidio: add mport char device driver")
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rapidio/devices/rio_mport_cdev.c