]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: be2iscsi: Revert "Fix a theoretical leak in beiscsi_create_eqs()"
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 Dec 2020 12:18:26 +0000 (15:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:39 +0000 (11:25 +0100)
commit23045c5f49c74d162a7368f8c05c1ffceb53fd18
tree1d34e3d4a2a0d63d6252a010cc67ff5b9586aeab
parentfd2583d25c2346061f99881f44af86d027b98195
scsi: be2iscsi: Revert "Fix a theoretical leak in beiscsi_create_eqs()"

commit eeaf06af6f87e1dba371fbe42674e6f963220b9c upstream.

My patch caused kernel Oopses and delays in boot.  Revert it.

The problem was that I moved the "mem->dma = paddr;" before the call to
be_fill_queue().  But the first thing that the be_fill_queue() function
does is memset the whole struct to zero which overwrites the assignment.

Link: https://lore.kernel.org/r/X8jXkt6eThjyVP1v@mwanda
Fixes: 38b2db564d9a ("scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()")
Cc: stable <stable@vger.kernel.org>
Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/be2iscsi/be_main.c