]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
virt: sev-guest: Do not use host-controlled page order in cleanup path
authorCarlos López <clopez@suse.de>
Tue, 12 May 2026 10:00:41 +0000 (12:00 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 17 May 2026 18:45:07 +0000 (11:45 -0700)
commit23e6a1ca04ae44806439a5a446e62e4d42e80bb4
tree5a56958c66555bc3d55a4689f41082c0ac4aa319
parente7f24a388e703e505a7f8d014a428308b35e8f94
virt: sev-guest: Do not use host-controlled page order in cleanup path

When issuing an extended guest request (SVM_VMGEXIT_EXT_GUEST_REQUEST),
get_ext_report() allocates a buffer to retrieve a certificate blob from the
host, keeping track of its size in report_req->certs_len.

However, the host may return SNP_GUEST_VMM_ERR_INVALID_LEN, indicating
an invalid buffer size, as well as the expected length of such buffer.
get_ext_report() subsequently updates report_req->certs_len with the
host-controlled value, and cleans up the buffer by computing a page order
from such value. This is incorrect, as the host-provided length may not
match the page order of the original allocation, potentially resulting
in corruption in the page allocator.

Fix this by using alloc_pages_exact() instead, and reusing @npages to
compute the size passed to free_pages_exact(). For consistency, also
use @npages to compute the size when allocating the pages, even though
this last change has no functional effect.

Fixes: 3e385c0d6ce8 ("virt: sev-guest: Move SNP Guest Request data pages handling under snp_cmd_mutex")
Signed-off-by: Carlos López <clopez@suse.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Tested-by: Michael Roth <michael.roth@amd.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/virt/coco/sev-guest/sev-guest.c