]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tty: goldfish: Use tty_port_destroy() to destroy port
authorWang Weiyang <wangweiyang2@huawei.com>
Mon, 28 Mar 2022 11:58:44 +0000 (19:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:53:55 +0000 (16:53 +0200)
commit241fcb79dd1df276d80b19f5f6acc9eaaaa63309
treeafb8ca954a05b80ced52703be1073b4ec1892925
parentc528c3933191e2f0a8d74ac3ba6bc11e2f0fffb8
tty: goldfish: Use tty_port_destroy() to destroy port

[ Upstream commit 507b05063d1b7a1fcb9f7d7c47586fc4f3508f98 ]

In goldfish_tty_probe(), the port initialized through tty_port_init()
should be destroyed in error paths.In goldfish_tty_remove(), qtty->port
also should be destroyed or else might leak resources.

Fix the above by calling tty_port_destroy().

Fixes: 666b7793d4bf ("goldfish: tty driver")
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com>
Link: https://lore.kernel.org/r/20220328115844.86032-1-wangweiyang2@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/goldfish.c