]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regulator: gpio: Fix the out-of-bounds access to drvdata::gpiods
authorManivannan Sadhasivam <mani@kernel.org>
Thu, 3 Jul 2025 10:35:49 +0000 (16:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 14:03:05 +0000 (16:03 +0200)
commit24418bc77a66cb5be9f5a837431ba3674ed8b52f
treeb4b7e464e6da0a90c9d6add9051a4330cc4a2ab2
parent0506547f6e3d2a1db4e3967975b65f46d12e331c
regulator: gpio: Fix the out-of-bounds access to drvdata::gpiods

commit c9764fd88bc744592b0604ccb6b6fc1a5f76b4e3 upstream.

drvdata::gpiods is supposed to hold an array of 'gpio_desc' pointers. But
the memory is allocated for only one pointer. This will lead to
out-of-bounds access later in the code if 'config::ngpios' is > 1. So
fix the code to allocate enough memory to hold 'config::ngpios' of GPIO
descriptors.

While at it, also move the check for memory allocation failure to be below
the allocation to make it more readable.

Cc: stable@vger.kernel.org # 5.0
Fixes: d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20250703103549.16558-1-mani@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/regulator/gpio-regulator.c