]> git.ipfire.org Git - thirdparty/util-linux.git/commit
umount: consider helper return status for success message
authorChristian Goeschel Ndjomouo <cgoesc2@wgu.edu>
Sun, 12 Oct 2025 03:09:27 +0000 (23:09 -0400)
committerChristian Goeschel Ndjomouo <cgoesc2@wgu.edu>
Mon, 13 Oct 2025 15:52:14 +0000 (11:52 -0400)
commit24478afdf0a1941e9b7049ef263677f666e73c80
tree6f209086cf17b052c096b197ec841ba1fc18e13b
parentdb0efab5c3e13794ae79fcb3db8371e3af510169
umount: consider helper return status for success message

If a helper function was executed to unmount, we simply return
without any user feedback. That can unintentionally surpress
verbose messages (`--verbose`) for non-root users who use udisks2
to mount filesystems, and unmount via the unmount.udisks2 helper.

It would be better to check the helper return status as well for
completeness and a more reliable way to test the success of the
unmount operation.

mnt_context_get_helper_status() is only called if the helper was
executed, i.e. mnt_context_helper_executed == 1, anything else
wouldnt make sense anyways.

Addresses: #3790
Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>
libmount/src/context_mount.c
sys-utils/umount.c