]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtc: check if __rtc_read_time was successful in rtc_timer_do_work()
authorYongliang Gao <leonylgao@tencent.com>
Fri, 11 Oct 2024 04:31:53 +0000 (12:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:20 +0000 (19:51 +0100)
commit246f621d363988e7040f4546d20203dc713fa3e1
tree56256a44a956f41f2166b30f302fd039b04e9dfe
parent7c6098bdb62a503ac5b1a6a420ff294a5f04b5b9
rtc: check if __rtc_read_time was successful in rtc_timer_do_work()

[ Upstream commit e8ba8a2bc4f60a1065f23d6a0e7cbea945a0f40d ]

If the __rtc_read_time call fails,, the struct rtc_time tm; may contain
uninitialized data, or an illegal date/time read from the RTC hardware.

When calling rtc_tm_to_ktime later, the result may be a very large value
(possibly KTIME_MAX). If there are periodic timers in rtc->timerqueue,
they will continually expire, may causing kernel softlockup.

Fixes: 6610e0893b8b ("RTC: Rework RTC code to use timerqueue for events")
Signed-off-by: Yongliang Gao <leonylgao@tencent.com>
Acked-by: Jingqun Li <jingqunli@tencent.com>
Link: https://lore.kernel.org/r/20241011043153.3788112-1-leonylgao@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/interface.c