]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
libertas: make lbs_ibss_join_existing() return error code on rates overflow
authorNicolai Stange <nstange@suse.de>
Tue, 14 Jan 2020 10:39:03 +0000 (11:39 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:02:16 +0000 (19:02 +0100)
commit2485578fc363bfc01012027cca4a746993a5df52
tree7cdfeb49b2cb5bcded86946efa3cc5734890f04a
parentf19d773f4a3192baf31500e77d4088c8e1be248c
libertas: make lbs_ibss_join_existing() return error code on rates overflow

commit 1754c4f60aaf1e17d886afefee97e94d7f27b4cb upstream.

Commit e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss
descriptor") introduced a bounds check on the number of supplied rates to
lbs_ibss_join_existing() and made it to return on overflow.

However, the aforementioned commit doesn't set the return value accordingly
and thus, lbs_ibss_join_existing() would return with zero even though it
failed.

Make lbs_ibss_join_existing return -EINVAL in case the bounds check on the
number of supplied rates fails.

Fixes: e5e884b42639 ("libertas: Fix two buffer overflows at parsing bss descriptor")
Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
[bwh: Backported to 3.16: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/libertas/cfg.c