git.ipfire.org Git - thirdparty/libvirt.git/commit

author	Peter Krempa <pkrempa@redhat.com>
	Mon, 28 Nov 2022 16:08:31 +0000 (17:08 +0100)
committer	Peter Krempa <pkrempa@redhat.com>
	Thu, 19 Sep 2024 08:30:15 +0000 (10:30 +0200)
commit	24d468993ce9cfe6e8add857e84702e6aa1309d9
tree	747055c05d951f25f789762fb4623e44a07aea8c	tree
parent	37789642076a911e8478c02d7cf2749872fa82fb	commit \| diff

qemu: Reject unsupported chardev backend protocols

QEMU supports only 'raw' and 'telnet' in the

<protocol type='telnets'/>

element. Reject 'telnets' and 'tls'. TLS transport for qemu chardevs is
configured via "tls='yes'" attribute added to the "<source>" element
instead, so this prevents potential misconfig as the value would be
silently accepted.

Closes: https://gitlab.com/libvirt/libvirt/-/issues/412
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

src/qemu/qemu_validate.c		diff \| blob \| blame \| history
tests/qemuxmlconfdata/serial-tcp-chardev-telnets.x86_64-latest.err	[new file with mode: 0644]	blob
tests/qemuxmlconfdata/serial-tcp-chardev-telnets.xml	[new file with mode: 0644]	blob
tests/qemuxmlconftest.c		diff \| blob \| blame \| history