]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rcu-tasks: Repair RCU Tasks Trace quiescence check
authorPaul E. McKenney <paulmck@kernel.org>
Mon, 4 Dec 2023 17:33:29 +0000 (09:33 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:07:34 +0000 (13:07 +0200)
commit24e5e1eff8ba236e6c87fd2938a1f79aa1e83f8e
treeca4be1088808356ff25cd0cfb18e26e9d8ccaf90
parent4d58c9fb45c70e62c19e8be3f3605889c47601bc
rcu-tasks: Repair RCU Tasks Trace quiescence check

[ Upstream commit 2eb52fa8900e642b3b5054c4bf9776089d2a935f ]

The context-switch-time check for RCU Tasks Trace quiescence expects
current->trc_reader_special.b.need_qs to be zero, and if so, updates
it to TRC_NEED_QS_CHECKED.  This is backwards, because if this value
is zero, there is no RCU Tasks Trace grace period in flight, an thus
no need for a quiescent state.  Instead, when a grace period starts,
this field is set to TRC_NEED_QS.

This commit therefore changes the check from zero to TRC_NEED_QS.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Tested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/rcupdate.h