]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: stmmac: do not clear TBS enable bit on link up/down
authorEsben Haabendal <esben@geanix.com>
Fri, 26 Jan 2024 09:10:41 +0000 (10:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2024 08:25:03 +0000 (09:25 +0100)
commit2524299b610667fe516ee4249a21978cb714cb00
tree3659f2ef8e0ca72308b05de73cb26da20b2cc4cb
parent923dea2a7ea9e1ef5ac4031fba461c1cc92e32b8
net: stmmac: do not clear TBS enable bit on link up/down

commit 4896bb7c0b31a0a3379b290ea7729900c59e0c69 upstream.

With the dma conf being reallocated on each call to stmmac_open(), any
information in there is lost, unless we specifically handle it.

The STMMAC_TBS_EN bit is set when adding an etf qdisc, and the etf qdisc
therefore would stop working when link was set down and then back up.

Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
Cc: stable@vger.kernel.org
Signed-off-by: Esben Haabendal <esben@geanix.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c