]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vhost/scsi: potential memory corruption
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 Feb 2015 07:37:33 +0000 (10:37 +0300)
committerJiri Slaby <jslaby@suse.cz>
Tue, 2 Jun 2015 10:32:54 +0000 (12:32 +0200)
commit266ed50f2a81a882d54c4ff7452bca370f396bae
treedb0e4a3de10118449b0410b15c58580b74c0e97a
parentec61e07b4192d5bbc5fb3ef80d7e6e36e09ddf57
vhost/scsi: potential memory corruption

commit 59c816c1f24df0204e01851431d3bab3eb76719c upstream.

This code in vhost_scsi_make_tpg() is confusing because we limit "tpgt"
to UINT_MAX but the data type of "tpg->tport_tpgt" and that is a u16.

I looked at the context and it turns out that in
vhost_scsi_set_endpoint(), "tpg->tport_tpgt" is used as an offset into
the vs_tpg[] array which has VHOST_SCSI_MAX_TARGET (256) elements so
anything higher than 255 then it is invalid.  I have made that the limit
now.

In vhost_scsi_send_evt() we mask away values higher than 255, but now
that the limit has changed, we don't need the mask.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/vhost/scsi.c