]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
block: don't silently ignore metadata for sync read/write
authorChristoph Hellwig <hch@lst.de>
Tue, 19 Aug 2025 08:25:01 +0000 (10:25 +0200)
committerChristian Brauner <brauner@kernel.org>
Wed, 20 Aug 2025 09:13:01 +0000 (11:13 +0200)
commit2729a60bbfb9215997f25372ebe9b7964f038296
tree16051bba1c512df574b0f52b9c8a538b1d365faa
parentd072148a8631f102de60ed5a3a827e85d09d24f0
block: don't silently ignore metadata for sync read/write

The block fops don't try to handle metadata for synchronous requests,
probably because the completion handler looks at dio->iocb which is not
valid for synchronous requests.

But silently ignoring metadata (or warning in case of
__blkdev_direct_IO_simple) is a really bad idea as that can cause
silent data corruption if a user ever shows up.

Instead simply handle metadata for synchronous requests as the completion
handler can simply check for bio_integrity() as the block layer default
integrity will already be freed at this point, and thus bio_integrity()
will only return true for user mapped integrity.

Fixes: 3d8b5a22d404 ("block: add support to pass user meta buffer")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/20250819082517.2038819-3-hch@lst.de
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
block/fops.c