]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
clk: rockchip: drop GRF dependency for rk3328/rk3036 pll types
authorPeter Geis <pgwipeout@gmail.com>
Wed, 28 Jul 2021 18:00:28 +0000 (14:00 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Sep 2021 11:40:11 +0000 (13:40 +0200)
commit273ed4f47e6f02303bd7998ceee1431349674f43
treeadfba1c6f2178234397b0b495c19a121c0659e71
parentf1eccc40816852e8a74a70cace71bdff336e14cb
clk: rockchip: drop GRF dependency for rk3328/rk3036 pll types

[ Upstream commit 6fffe52fb336ec2063270a7305652a93ea677ca1 ]

The rk3036/rk3328 pll types were converted to checking the lock status
via the internal register in january 2020, so don't need the grf
reference since then.

But it was forgotten to remove grf check when deciding between the
pll rate ops (read-only vs. read-write), so a clock driver without
the needed grf reference might've been put into the read-only mode
just because the grf reference was missing.

This affected the rk356x that needs to reclock certain plls at boot.

Fix this by removing the check for the grf for selecting the utilized
operations.

Suggested-by: Heiko Stuebner <heiko@sntech.de>
Fixes: 7f6ffbb885d1 ("clk: rockchip: convert rk3036 pll type to use internal lock status")
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
[adjusted the commit message, adjusted the fixes tag]
Link: https://lore.kernel.org/r/20210728180034.717953-3-pgwipeout@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/rockchip/clk-pll.c