]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcm_qla2xxx: Fix incorrect use of __transport_register_session
authorBart Van Assche <bart.vanassche@sandisk.com>
Fri, 20 Mar 2015 05:25:16 +0000 (22:25 -0700)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 12:14:05 +0000 (14:14 +0200)
commit27454f094cdc9571564d3edf335cd78e9ed8b9e8
tree27b68ffe2af46591b3f93d8050338a798458d02a
parent587959936850fb22f787af167f4ac982d605f5b0
tcm_qla2xxx: Fix incorrect use of __transport_register_session

commit 75c3d0bf9caebb502e96683b2bc37f9692437e68 upstream.

This patch fixes the incorrect use of __transport_register_session()
in tcm_qla2xxx_check_initiator_node_acl() code, that does not perform
explicit se_tpg->session_lock when accessing se_tpg->tpg_sess_list
to add new se_sess nodes.

Given that tcm_qla2xxx_check_initiator_node_acl() is not called with
qla_hw->hardware_lock held for all accesses of ->tpg_sess_list, the
code should be using transport_register_session() instead.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Quinn Tran <quinn.tran@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/scsi/qla2xxx/tcm_qla2xxx.c