]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 23 Feb 2021 20:30:21 +0000 (17:30 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 23 Feb 2021 20:30:21 +0000 (17:30 -0300)
commit2796ae2ad25330e80e97e823aa72091a9374d87d
tree256ed63bc72725fa60f0c4e84ef34a7a8c9358cd
parent67b3ee292935352b4b12b7a1bce17c64f85ce32e
Reinstate HEAP_XMAX_LOCK_ONLY|HEAP_KEYS_UPDATED as allowed

Commit 866e24d47db1 added an assert that HEAP_XMAX_LOCK_ONLY and
HEAP_KEYS_UPDATED cannot appear together, on the faulty assumption that
the latter necessarily referred to an update and not a tuple lock; but
that's wrong, because SELECT FOR UPDATE can use precisely that
combination, as evidenced by the amcheck test case added here.

Remove the Assert(), and also patch amcheck's verify_heapam.c to not
complain if the combination is found.  Also, out of overabundance of
caution, update (across all branches) README.tuplock to be more explicit
about this.

Author: Julien Rouhaud <rjuju123@gmail.com>
Reviewed-by: Mahendra Singh Thalor <mahi6run@gmail.com>
Reviewed-by: Dilip Kumar <dilipbalaut@gmail.com>
Discussion: https://postgr.es/m/20210124061758.GA11756@nol
src/backend/access/heap/README.tuplock