]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commit
kernel: Fix path comparison in kernel staging dir symlinking
authorStaffan Rydén <staffan.ryden@axis.com>
Thu, 20 Jul 2023 11:02:56 +0000 (13:02 +0200)
committerSteve Sakoman <steve@sakoman.com>
Mon, 11 Sep 2023 15:19:51 +0000 (05:19 -1000)
commit27a982807caa7ffbdf2d4ef02bc0b037150b1b3b
tree75275eba7542c9208e7767b1475432004d531c1f
parent31b996c01c72749fc62821a3c9d1da70540bfad6
kernel: Fix path comparison in kernel staging dir symlinking

Due to an oversight in the do_symlink_kernsrc function, the path
comparison between "S" and "STAGING_KERNEL_DIR" is broken. The code
obtains both variables, but modifies the local copy of "S" before
comparing them, causing the comparison to always return false.

This can cause the build to fail when the EXTERNALSRC flag is enabled,
since the code will try to create a symlink even if one already exists.

This patch resolves the issue by comparing the variables before they are
modified.

Signed-off-by: Staffan Rydén <staffan.ryden@axis.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
(cherry picked from commit afd2038ef8a66a5e6433be31a14e1eb0d9f9a1d3)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/kernel.bbclass