]> git.ipfire.org Git - thirdparty/libvirt.git/commit
security: aa-helper: generate more rules for gl devices
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>
Tue, 12 Feb 2019 10:12:52 +0000 (11:12 +0100)
committerChristian Ehrhardt <christian.ehrhardt@canonical.com>
Mon, 25 Feb 2019 07:57:33 +0000 (08:57 +0100)
commit27a9ebf28183cb3c3c784fcab622e67e978eb3dc
treed8235311173540cca1133d2bff3e13cebd166cd6
parentd85e8e400b48f1b4c1dfbf438dda83cd959eacf7
security: aa-helper: generate more rules for gl devices

Change fb01e1a44 "virt-aa-helper: generate rules for gl enabled
graphics devices" implemented the detection for gl enabled
devices in virt-aa-helper. But further testing showed
that it will need much more access for the full gl stack
to work.

Upstream apparmor just recently split those things out and now
has two related abstractions at
https://gitlab.com/apparmor/apparmor/blob/master:
- dri-common at /profiles/apparmor.d/abstractions/dri-common
- mesa: at /profiles/apparmor.d/abstractions/mesa

If would be great to just include that for the majority of
rules, but they are not yet in any distribution so we need
to add rules inspired by them based on the testing that we
can do.

Furthermore qemu with opengl will also probe the backing device
of the rendernode for attributes which should be safe as
read-only wildcard rules.

Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1815452
Acked-by: Jamie Strandboge <jamie@canonical.com>
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
src/security/virt-aa-helper.c